Improve log messages - #730
Conversation
| : "" | ||
| }`, | ||
| ); | ||
| process.exit(result.exitCode); |
There was a problem hiding this comment.
This isn't needed as I changed to a throw above, which core.setFailed will make the exit code 1 by default. But while this might be a different exit code than result.exitCode, it doesn't matter in practice as GitHub Actions only has two states: success and failure, which are checked by 0 and non-0 only.
| base: branch, | ||
| }); | ||
| core.info( | ||
| core.debug( |
There was a problem hiding this comment.
I find this info to bloat the logs in practice, so moved this to debug, which can be viewed when the user re-runs the action in debug mode.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
🦋 Changeset detectedLatest commit: 72988d2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
beeequeue
left a comment
beeequeue
left a comment
There was a problem hiding this comment.
i had a todo item to remove the logging of a big json object from the action, but i cant remember if we did that already
|
The big json object is this which I move to |
3 participants
Did a subjective pass and tried to improve/make more consistent of the log messages